-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix: correct outdated fedora/CentOs/RHEL install guide #8114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
184b884
to
89ecbbe
Compare
Installation method in Fedora/CentOs/RHEL space has changed in the last few years, moving away from using modules to using traditional rpms for all maintained stream versions.
89ecbbe
to
f036d6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
For people want to verify this pr https://developer.fedoraproject.org/tech/languages/nodejs/nodejs.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the installation instructions for Node.js on Fedora, CentOS, and RHEL systems to reflect current package management practices. The documentation has been modernized to show the transition from module-based installation to traditional RPM packages for maintained distributions.
- Updated installation method from modules to traditional dnf package installation for current Fedora and RHEL 10
- Added instructions for installing specific Node.js versions using stream-specific packages
- Clarified that module-based installation is only for older CentOS/RHEL releases
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: tjuhaszrh <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: tjuhaszrh <[email protected]>
Co-authored-by: Michael Esteban <[email protected]> Signed-off-by: tjuhaszrh <[email protected]>
Co-authored-by: Michael Esteban <[email protected]> Signed-off-by: tjuhaszrh <[email protected]>
Co-authored-by: Michael Esteban <[email protected]> Signed-off-by: tjuhaszrh <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8114 +/- ##
==========================================
+ Coverage 75.89% 76.60% +0.70%
==========================================
Files 113 115 +2
Lines 9459 9595 +136
Branches 307 321 +14
==========================================
+ Hits 7179 7350 +171
+ Misses 2279 2244 -35
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tjuhaszrh !
Description
Installation method in Fedora/CentOs/RHEL space has changed in the last few years, moving away from using modules to using traditional rpms for all maintained stream versions.
Quick search on google suggests that this created at-least some confusion with the conflicting content of the page modified in this PR.
Related Issues
No related issues
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.